Codecov Report

Merging #1330 (d604fea) into dev (3826f1a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1330   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files          22       22           
  Lines        7828     7829    +1     
=======================================
+ Hits         6531     6532    +1     
  Misses       1297     1297           

@yitam Hi! Where should I add new tests?

Thanks @mpyw but we only accept PRs to dev branch. For new tests please add them to test\functional\pdo_sqlsrv

All CLA requirements met.

@mpyw your change looks good. Thanks for catching this.

For your test, it's similar to our existing test "pdo_lastInsertId.phpt", but your calls to lastInsertId() would not end up in the exception would they?

To prove that your change has any effect, please put something like the following after one of the calls to lastInsertId(), to force an exception to occur:

    $tsql = "SELECT * FROM dummy";
    $conn->exec($tsql);

Also, change the catch block to be something like this:

} catch (PDOException $e) {
    var_dump($e->getMessage());
    exit;
}

@yitam Thanks! How do I confirm the actual message?

https://dev.azure.com/sqlclientdrivers-ci/msphpsql/_build/results?buildId=43949&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=db4cbda1-d56a-5b77-22ca-3127ec460827

@mpyw you don't have to match the exact message, but this is my suggestion (please drop the test tables first):

    dropTable($conn, "table3");

    $tsql = "SELECT * FROM dummy";
    $conn->exec($tsql);

    unset($conn);
} catch (PDOException $e) {
    print_r($e->getMessage());
    exit;
}


?>
--EXPECTREGEX--
string\(3\) "200"
string\(3\) "102"
(string\(0\) ""|bool\(false\))
.*Invalid object name \'dummy\'\.